[refactor] exit 응답 추가 #97
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dlsrks1021
approved these changes
Jul 20, 2025
|
|
||
| messageSender.send(destination, MessageType.PLAYER_LIST, playerListResponse); | ||
| messageSender.send(destination, MessageType.SYSTEM_NOTICE, systemNoticeResponse); | ||
| messageSender.send( |
Collaborator
There was a problem hiding this comment.
[L5-참고의견]
exit_success 타입의 메시지가 브로드캐스팅 되는 형태이기 때문에,
프론트에서 분기 처리가 필요하다는 요청이 전해져야 할 것 같습니다.
(조건 없이 exit_success를 받을 때 구독을 해제하는 형태로 구현하시면 많이 꼬일 것 같습니다..)
Collaborator
Author
There was a problem hiding this comment.
경찬님! 진짜 중요포인트 찝어 주셔서 감사합니다. 브로드캐스팅이아니라 1:1 응답 줄 수 있는 방법 있는걸로 아는데 그렇게 구현 변경하도록 하겠습니다! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛰️ Issue Number
🪐 작업 내용
send요청과disconnect요청이 비동기처리로 순서가 보장되지 않아서 exit 로직이 정상 실행되지 않을 가능성이 있음exit요청시 성공 여부를 응답true반환, 플레이어 삭제시는isRemoved플래그를 반환📚 Reference
✅ Check List